Fixed #9511 - Validation For Encrypted Custom Fields#17456
Merged
snipe merged 7 commits intogrokability:developfrom Aug 5, 2025
Merged
Conversation
Collaborator
Author
|
@snipe poking for a review on this |
Member
|
This looks very clean - I kinda wish we had Birgit around to test a bit more manually, but it seems good. |
2 tasks
Yvejen
pushed a commit
to Yvejen/snipe-it
that referenced
this pull request
Nov 19, 2025
…on-always-fails-on-encrypted-custom-fields Fixed grokability#9511 - Validation For Encrypted Custom Fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation now works on all available formats for encrypted custom fields. I had written a couple of these rules a while back and did the validation manually using PHP native methods, but I switched to using the Laravel methods for this and expanded it to all of the available formats. Doesn't look like much, but took some time to get everything working, especially the custom regex format.
Fixes #9511