Skip to content

Fixed #17620 - DELETE method on custom fields causing method not allowed error#17625

Merged
snipe merged 8 commits intodevelopfrom
#17620-delete-method-custom-fields
Aug 17, 2025
Merged

Fixed #17620 - DELETE method on custom fields causing method not allowed error#17625
snipe merged 8 commits intodevelopfrom
#17620-delete-method-custom-fields

Conversation

@snipe
Copy link
Copy Markdown
Member

@snipe snipe commented Aug 17, 2025

Recent changes to the modals in the snipeit.js file caused a slightly different behavior for older screens that aren't using the server-side bootstrap tables formatters. Eventually these should just be converted into API calls, but for now, this uses the correct modal that passes the href and replaces the form action via the modal script in snipeit.js.

Fixes #17620

snipe added 6 commits August 17, 2025 13:30
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe requested a review from uberbrady as a code owner August 17, 2025 12:36
@snipe
Copy link
Copy Markdown
Member Author

snipe commented Aug 17, 2025

I'm seeing some failing tests that seem kind of unrelated other than it might have to do with the trim() I added to the error handler. Looking into it.

snipe added 2 commits August 17, 2025 14:06
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 6dceefb into develop Aug 17, 2025
7 of 8 checks passed
@snipe snipe deleted the #17620-delete-method-custom-fields branch August 17, 2025 13:11
@snipe snipe changed the title Fixed #17620 - delete method custom fields causing method not allowed error Fixed #17620 - DELETE method on custom fields causing method not allowed error Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant