Skip to content

Adds #5554 locale for acceptance notifications and checkin/out emails#17713

Merged
snipe merged 3 commits intogrokability:developfrom
Godmartinz:fix-localization-for-email-notifications
Aug 28, 2025
Merged

Adds #5554 locale for acceptance notifications and checkin/out emails#17713
snipe merged 3 commits intogrokability:developfrom
Godmartinz:fix-localization-for-email-notifications

Conversation

@Godmartinz
Copy link
Copy Markdown
Member

@Godmartinz Godmartinz commented Aug 25, 2025

This uses the locale of the $assigned_user for acceptance emails and checkin/out
The system's locale is used for alert emails and cc emails.

This fires the Mail::to() twice in the checkoutable listener. This is the best way I could think of to handle the different locales for this process.

Fixes: #5554

@Godmartinz Godmartinz requested a review from snipe as a code owner August 25, 2025 19:25
@Godmartinz Godmartinz changed the title adds locale for acceptance notifications and checkin/out emails Adds #5554 locale for acceptance notifications and checkin/out emails Aug 25, 2025
@Godmartinz Godmartinz linked an issue Aug 25, 2025 that may be closed by this pull request
@snipe
Copy link
Copy Markdown
Member

snipe commented Aug 26, 2025

Looks like you've got some failing tests here:

FAILED Tests\Feature\Notifications\Email\EmailNotificationsToAdminAlertE…
The expected [App\Mail\CheckoutAssetMail] mailable was not sent.
Failed asserting that false is true.

@Godmartinz
Copy link
Copy Markdown
Member Author

Tests are fixed. We no longer fire off an attached cc() to the mailable, and it fires an additional email for different localization. Updated the test accordingly.

@snipe snipe merged commit 745fc51 into grokability:develop Aug 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language of acceptance email

2 participants