Adds #5554 locale for acceptance notifications and checkin/out emails#17713
Merged
snipe merged 3 commits intogrokability:developfrom Aug 28, 2025
Merged
Conversation
Member
|
Looks like you've got some failing tests here: FAILED Tests\Feature\Notifications\Email\EmailNotificationsToAdminAlertE… |
Member
Author
|
Tests are fixed. We no longer fire off an attached |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the locale of the
$assigned_userfor acceptance emails and checkin/outThe system's locale is used for alert emails and cc emails.
This fires the
Mail::to()twice in the checkoutable listener. This is the best way I could think of to handle the different locales for this process.Fixes: #5554