Skip to content

Fixes #17642 Checkouts to location email for Assets and Accessories#17724

Merged
snipe merged 3 commits intogrokability:developfrom
Godmartinz:checkout2location_email_fix
Aug 27, 2025
Merged

Fixes #17642 Checkouts to location email for Assets and Accessories#17724
snipe merged 3 commits intogrokability:developfrom
Godmartinz:checkout2location_email_fix

Conversation

@Godmartinz
Copy link
Copy Markdown
Member

@Godmartinz Godmartinz commented Aug 26, 2025

This fixes the salutation and intro message when checking out to a location. Locations are suppose to be addressed to the manager of the location. Also the message was misleading, as it sounded like it was being checked out to the manager and not the location.

Before:
image

After:
There is a new translation for checking out to location as well:
image

This change was also applied to accessories:
image

Fixes: #17642

@Godmartinz Godmartinz requested a review from marcusmoore August 26, 2025 23:06
@Godmartinz Godmartinz requested a review from snipe as a code owner August 26, 2025 23:06
@Godmartinz Godmartinz linked an issue Aug 26, 2025 that may be closed by this pull request
@Godmartinz
Copy link
Copy Markdown
Member Author

Godmartinz commented Aug 26, 2025

I added a coma after the location in the translation 😅

Copy link
Copy Markdown
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏾

@snipe snipe merged commit 2f77fcb into grokability:develop Aug 27, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checked out Asset to Location Email

3 participants