Fixed #17796 - search on model name and number on importer#17797
Merged
Fixed #17796 - search on model name and number on importer#17797
Conversation
Signed-off-by: snipe <snipe@snipe.net>
Member
Author
|
Hm, not sure why these tests are failing - the import does work as far as I can see. |
Member
Author
seems like it might be the culprit. Which is kinda weird since I didn't touch any notifications, and also, it's failing on the asset model import, which doesn't notify anyone. |
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Member
Author
|
Sigh. Failing on mysql, passing on SQLite, for no reason I can determine. :-/ |
Member
Author
|
I cannot get the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does the comparison on model name and model number for the importer so that models with the same name but different numbers can be imported.