Conversation
uberbrady
approved these changes
Sep 15, 2025
Member
uberbrady
left a comment
uberbrady
left a comment
There was a problem hiding this comment.
This seems great! I saw one place where there's some duplicated code I think, and I had some questions about the factory choices you made, but nothing that should block the PR. Thanks for getting this handled!
This was referenced Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds onto #17858, hiding expired and terminated licenses from the regular view and also fixes an issue with the checkin button not appearing on license default view under the assigned list.