Add new index to users over deleted_at and location_id#17876
Merged
snipe merged 1 commit intogrokability:developfrom Sep 16, 2025
Merged
Add new index to users over deleted_at and location_id#17876snipe merged 1 commit intogrokability:developfrom
snipe merged 1 commit intogrokability:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some location-based queries that join to Users, when there are lots of users, can be slower than they need to be, so this adds an index.
One thing we're doing that's a little weirder than usual is that we're indexing
deleted_atfirst, then doinglocation_id. This is because we could probably use an index over usersdeleted_atat some point, and this index will cover that. But we're never going to ask for "all users from this location regardless of whether they're deleted or not" - we always ask for eitherdeleted_at IS NULLordeleted_at IS NOT NULL.