Fixed #17919 - correct the behavior of the checkout type selector#17923
Merged
snipe merged 3 commits intogrokability:developfrom Sep 24, 2025
Merged
Fixed #17919 - correct the behavior of the checkout type selector#17923snipe merged 3 commits intogrokability:developfrom
snipe merged 3 commits intogrokability:developfrom
Conversation
This was referenced Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a problem where, if you had checked an asset out to a non-User, when you would go back to checking out another asset, it would correctly highlight the last 'type' of thing you checked out and would actually show the correct drop-down menu, but it would not select the correct invisible radio button to state what the correct
checkout_to_typewas.Additionally, when you would go to the checkout screen on a fresh session, no type of checkout target was selected. Whereas we had used to default to showing the User dropdown.
This fixes both of those issues.
It was really tempting (and I wrote it at first this way) to do some kind of
@php...@endphpthing to determine$active_checkout_typeand then take action on that to prevent us from repeatingsession('checkout_to_type')orsession('checkout_to_type') ?? 'user'as often as we do, but that seemed like just extra noise and we tend to actively avoid@phpsections, so I went with this simpler approach.Fixes #17919