Skip to content

Fixed #17919 - correct the behavior of the checkout type selector#17923

Merged
snipe merged 3 commits intogrokability:developfrom
uberbrady:fix_checkout_type_selector2
Sep 24, 2025
Merged

Fixed #17919 - correct the behavior of the checkout type selector#17923
snipe merged 3 commits intogrokability:developfrom
uberbrady:fix_checkout_type_selector2

Conversation

@uberbrady
Copy link
Copy Markdown
Member

We had a problem where, if you had checked an asset out to a non-User, when you would go back to checking out another asset, it would correctly highlight the last 'type' of thing you checked out and would actually show the correct drop-down menu, but it would not select the correct invisible radio button to state what the correct checkout_to_type was.

Additionally, when you would go to the checkout screen on a fresh session, no type of checkout target was selected. Whereas we had used to default to showing the User dropdown.

This fixes both of those issues.

It was really tempting (and I wrote it at first this way) to do some kind of @php...@endphp thing to determine $active_checkout_type and then take action on that to prevent us from repeating session('checkout_to_type') or session('checkout_to_type') ?? 'user' as often as we do, but that seemed like just extra noise and we tend to actively avoid @php sections, so I went with this simpler approach.

Fixes #17919

@uberbrady uberbrady requested a review from snipe as a code owner September 24, 2025 13:43
@snipe snipe merged commit 7d07420 into grokability:develop Sep 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants