New legend styles and additional help hints for LDAP#18063
Merged
Conversation
snipe
changed the title
snipe
deleted the
improved-fieldset-UI-and-better-help-test-for-ldap-mapping
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new style for legends, adds a few small blade components to handle "tips" within the legends (inspired by recent GH issues) and the legends themselves.
Before
After
Still lots more to do to standardize the legends, since LDAP is the only place for now that uses the new way, but I think this looks nicer and is more helpful.
I loathe having to use code inside of translations, but it gets waaaay too messy doing it any other way. :(