Fixed #18065: Ensure that private_key_bits is always an int

[smarsching]

This PR fixes #18065 by ensuring that private_key_bits is cast to an int before passing it to openssl_pkey_new.

[snipe]

Hi there - thanks for this! It looks like the branch you were working from might be a bit out of a date. I can see a bunch of my own commits in this PR, which can make it kinda confusing to see what's actually changed. Can you please rebase and do another push to this PR branch? That will clean things up a bit.

To Rebase

Assuming you started with this repo as the origin, and added yourself as a named remote:

git fetch origin; git rebase origin/develop

otherwise git fetch whatever your remote is.

Thanks so much!

[smarsching]

@snipe Thanks for pointing this out. I accidentally created the branch on top of the master branch, but then opened the PR against the develop branch. Apparently this was preselected and I didn’t check. Which one is the correct branch for bugfix PR?

For the moment, I rebased the branch, so that you can easily compare (the fix is a single line, so I can easily cherry-pick it and apply it on top of any branch).

[snipe]

Thanks! PRs should always target the develop branch (unless otherwise expressly stated), per our Contributing documentation.

[smarsching]

Thanks for merging the PR and pointing me to the contributing guidelines. I had actually read them, but I had missed the part about the branch. 🙈