Fixed audit images not displaying inline#18074
Merged
Conversation
snipe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit preview images were not loading in the audits tab previously. This PR fixes that.
Down the line, we need to normalize some of these weird exceptions. Audits don't have their own model, and while the new file uploads controller is a LOT cleaner than what we had, we have to shim in a few things where the FCO doesn't have a model, OR when the URL name or model name doesn't exactly match the directory.
This just fixes the missing audit image preview, but I'll work more on the file uploads controllers later.
(We should really be allowing uploads in general for audits, since it might include pdfs, etc, not just images, but that's a different PR.)