Moved Traits into its directory and modify the FCO's to point to them#18076
Merged
snipe merged 1 commit intogrokability:developfrom Oct 27, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the two Traits of
RequestableandLoggableinto the Traits sub-directory of the Models directory.Unfortunately my IDE decided to re-order some of them, which adds a little bit of noise, but generally this looks pretty smooth. One thing I did have to do was a
composer dumpto clean out the various class-caches and whatnot that Composer uses. I'm pretty sure we recommend that (and automate it) so I don't think that should be too much of a problem.I decided not to move the single Interface we have into an Interfaces (or Contracts?) directory, since there's only one and I don't know how interested we are in making others.