Fixed expiring warranties not being included in the expiring alerts notification

[Godmartinz]

This refactors the getExpiringWarrantyOrEol() method without using whereRaw(). By breaking up the $expired_assets and $assets_with_warranties, we can manipulate the $expiration_window search on warranties easier using betweenIncluded() instead of whereRaw()

[snipe]

If the warrantees are already expired, I wouldn't think we'd still want them in the alerts, otherwise that list could end up getting very long, no?

[Godmartinz]

I meant this returns expiring warranties within the X days window given from the notification settings.

[Godmartinz]

I will rename that variable as well 😅

[snipe]

Does this fix a particular GH issue?