Fixed #17329 Audit Warning Threshold could be negative#18116
Merged
snipe merged 2 commits intogrokability:developfrom Oct 28, 2025
Merged
Fixed #17329 Audit Warning Threshold could be negative#18116snipe merged 2 commits intogrokability:developfrom
snipe merged 2 commits intogrokability:developfrom
Conversation
snipe
requested changes
Oct 28, 2025
Member
snipe
left a comment
snipe
left a comment
There was a problem hiding this comment.
You'll want to add min="0" to the HTML input field as well, to prevent the numeric stepper from allowing a negative.
Contributor
Author
yea i was wondering about that. but the field already was catching the input. |
Member
|
What res are you looking at that screen on? I'm curious why the layout looks so odd in your screenshot (right-aligned, and breaking down to the next line.) |
Contributor
Author
I usually do a lot of my coding with console open. here is it without. The op is at about 600x950 |
Member
|
Right, but on a smaller screen, it shouldn't be behaving like that (aligned right). I'll take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit Warning Threshold could be negative.
This fixes the field so it must be greater than or equal to 0.
The field can still be null.
Fixes #17329