Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a much smaller swing at the very large form row component I took earlier, handling only the manufacturers edit for now.
The form row component itself is a bit messy, since it's got two or more elements nested within it which we have to potentially pass things to, the label component and the input itself.
I decided to back off the complex checkbox groups and radio groups for now, because whew that gets messy.
This also fixes a long-running JS visual glitch that has made me bananas for a while, where if you have an input group (the bit with the icon on the end or the front of the input box, it would break the layout on the JS error.
The overall goal here is to take the HTML/bootstrap code away from the the functionality of the forms, fixing some common issues where form fields are weird lengths on different forms. This should add consistency to the layouts, and make it much easier to upgrade bootstrap (and/or switch to some other CSS framework) in the future.
Obviously, this will eventually touch just about form element we have, once I build in other ones, and will likely take the place of a lot of our partials over time. But this is at least a decent start.
Before
After
Screen.Recording.2025-10-29.at.4.21.27.PM.mov