Skip to content

Change title_class to ucfirst in Object Import Command to allow AssetModel#18306

Merged
snipe merged 1 commit intogrokability:developfrom
fdiaz3000:change-import-assetmodel
Dec 8, 2025
Merged

Change title_class to ucfirst in Object Import Command to allow AssetModel#18306
snipe merged 1 commit intogrokability:developfrom
fdiaz3000:change-import-assetmodel

Conversation

@fdiaz3000
Copy link
Copy Markdown
Contributor

Related to Issue #18305 php artisan snipeit:import --item-type=AssetModel error:
Class "App\Importer\AssetmodelImporter" not found
Change title_class to ucfirst in Object Import Command to allow AssetModel.

@fdiaz3000 fdiaz3000 requested a review from snipe as a code owner December 6, 2025 20:04
@snipe
Copy link
Copy Markdown
Member

snipe commented Dec 7, 2025

Hi there - thanks for this! Can you please re-target this PR to point to the develop branch, per our Contributing documentation? Also please provide tests or updates to existing tests to confirm your change will not break existing functionality.

You usually don't need to close and re-open. After you create a pull request, you can modify the base branch so that the changes in the pull request are compared against a different branch. By changing the base branch of your original pull request rather than opening a new one with the correct base branch, you’ll be able to keep valuable work and discussion.

mhuxq

Thanks!

@fdiaz3000 fdiaz3000 changed the base branch from master to develop December 7, 2025 15:13
@snipe snipe merged commit af4db94 into grokability:develop Dec 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants