Skip to content

Fixes #18325: Ensure existing permission group users are maintained when editing a group #18326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snipe merged 2 commits into from
Dec 19, 2025
Merged

Fixes #18325: Ensure existing permission group users are maintained when editing a group #18326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
242201c
Fix: Ensure existing permission group users are maintained when editi…
Dec 9, 2025
c978be5
send associated_users to view as collection
Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Http/Controllers/GroupsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function create(Request $request) : View
// Show the page
return view('groups/edit', compact('permissions', 'selectedPermissions', 'groupPermissions'))
->with('group', $group)
->with('associated_users', [])
->with('associated_users', collect())
->with('unselected_users', $users)
->with('all_users_count', $users_count);
}
Expand Down
2 changes: 1 addition & 1 deletion resources/views/groups/edit.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
@if(($all_users_count ) && ($all_users_count < config('app.max_unpaginated_records')))

<!-- This hidden input will store the selected user IDs as a comma-separated string to avoid max_input_vars and max_multipart_body_parts php.ini issues -->
<input type="hidden" name="users_to_sync" id="hidden_ids_box" class="form-control" value="{{ ($associated_users && is_array($associated_users)) ? implode(",", $associated_users->pluck('id')->toArray()) : '' }}"/>
<input type="hidden" name="users_to_sync" id="hidden_ids_box" class="form-control" value="{{ $associated_users->pluck('id')->implode(',') }}"/>

<div class="addremove-multiselect">
<div class="col-lg-5 col-sm-5 col-xs-12">
Expand Down
Loading