Added #17197: Ability to download uploaded import CSVs#18328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability for users to download previously uploaded import files. Superusers can download any of the uploaded imports, and non-superusers can only download imports they themselves have uploaded.
This also checks to see whether or not the user actually has permission to go to the FCO they are importing. Why wouldn't they be able to, you might ask? Beat me, but I've seen it happen. Previously, this would sad panda you, if for example you were importing categories (because you needed them for asset models, which you do have access to see), after you imported the categories, you'd end up at a sad panda, since you can't actually see categories. Now it will redirect you back to the import index if you don't have permission to see whatever it is you're importing.
This also disallows users who are not superusers from deleting files they don't own.
It also normalizes the .csv extension on download.