Replaced deprecated Symfony Request::get() usage#18363
Merged
snipe merged 1 commit intogrokability:developfrom Dec 21, 2025
Merged
Replaced deprecated Symfony Request::get() usage#18363snipe merged 1 commit intogrokability:developfrom
Request::get() usage#18363snipe merged 1 commit intogrokability:developfrom
Conversation
Member
|
You're the best. I've been slowly doing this over time, but sometimes it's better to rip the bandaid off. <3 |
Contributor
Author
|
🩹 Glad to help, these changes can be tedious and disruptive. Nice work on ripping off the band-aid! I am sure they are well-meaning from Symfony's perspective; it probably shouldn't have been doing more than the query string get parameters in the first place, but well... |
Request::get() usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After upgrading dependencies,
deprecations.logis flooded with:Laravel still exposes
get()through inheritance, but it now triggers Symfony’s deprecation path.This PR switches to Laravel’s recommended request accessors. As per this discussion laravel/framework#57993
What changed
Request::get('key')usage withrequest()->input('key')(and introduced small local variables in views to avoid repeated calls).->get('key')calls on request objects with->input('key'):$request->get(...)→$request->input(...)request()->get(...)→request()->input(...)$this->get(...)/$this->request->get(...)→$this->input(...)Files touched (high level)
resources/views/hardware/index.blade.php,resources/views/models/index.blade.php,resources/views/reports/asset.blade.phpcontrollers/requests/services): multiple inapp/Http/...plusapp/Services/PredefinedKitCheckoutService.phpExpected impact
Request::get()deprecation spampreferred accessor)