Skip to content

Fixed #18405: Clean up closing divs to fix footer position#18406

Merged
snipe merged 2 commits intogrokability:developfrom
dbakan:patch-1
Jan 7, 2026
Merged

Fixed #18405: Clean up closing divs to fix footer position#18406
snipe merged 2 commits intogrokability:developfrom
dbakan:patch-1

Conversation

@dbakan
Copy link
Copy Markdown
Contributor

@dbakan dbakan commented Jan 7, 2026

Fixes #18405 by removing some stray closing divs.

@dbakan dbakan requested a review from snipe as a code owner January 7, 2026 11:40
dbakan added 2 commits January 7, 2026 12:43
Removed redundant closing div tags in the edit view.
@snipe snipe merged commit bf910bc into grokability:develop Jan 7, 2026
7 checks passed
@dbakan dbakan deleted the patch-1 branch January 7, 2026 13:09
@swift2512
Copy link
Copy Markdown

swift2512 commented Jan 16, 2026

@dbakan there are other places with footer being in wrong position. :)

Assets > Requested - https://demo.snipeitapp.com/hardware/requested
People > LDAP Sync (disabled on demo)
(EDIT: Asset models are OK)

@snipe
Copy link
Copy Markdown
Member

snipe commented Jan 16, 2026

@swift2512 Not seeing it on the first two

Requested

Screenshot 2026-01-16 at 11 26 52 AM

LDAP

Screenshot 2026-01-16 at 11 27 39 AM

@swift2512
Copy link
Copy Markdown

@snipe it's Assets > Requested 😉 And it's present on DEMO.
It's also on my LDAP Sync page (Latest pull). Tested with MS Edge and Firefox on different computers.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants