Fixed #18402 - Clean up SAML readonly display#18410
Merged
Conversation
Member
Author
|
One thing I noticed was on the user edit/create screen, since we do some readonly shenanigans to prevent browsers from pre-populating email, passwords, etc, and the border color is a little off for the readonly fields. 
That last commit fixes it mostly, but there is still a slight difference in the field border. Light
Dark
I can take a look at fixing that a bit later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the disabled/read-only fields clearer
Light Normal
Dark Normal
Light Demo Mode
Dark Demo Mode
This also addresses read-only/disabled for other sections for example demo mode on the admin account.
Fixes #18402