Fix [RB-20479] Checkin/Checkout notifications from logging as errors#18418
Merged
snipe merged 2 commits intogrokability:developfrom Jan 14, 2026
Merged
Fix [RB-20479] Checkin/Checkout notifications from logging as errors#18418snipe merged 2 commits intogrokability:developfrom
snipe merged 2 commits intogrokability:developfrom
Conversation
Godmartinz
requested review from
marcusmoore and
snipe
and removed request for
snipe
marcusmoore
requested changes
Jan 8, 2026
Collaborator
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
This has a couple typos but overall is a good change.
marcusmoore
approved these changes
Jan 8, 2026
Collaborator
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
I haven't tested this but the code looks right to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes Checkin/Checkout notifications from logging as errors for everything. Status codes 500+ are now logged as errors and everything below is logged as a warning. This should make rollbars more truthy for notifications.
fixes: [RB-20479] [RB-20578]