Fixed - throw fewer exceptions on SCIM misconfigurations#18442
Merged
snipe merged 1 commit intogrokability:developfrom Jan 15, 2026
Merged
Fixed - throw fewer exceptions on SCIM misconfigurations#18442snipe merged 1 commit intogrokability:developfrom
snipe merged 1 commit intogrokability:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We very heavily use Rollbar in our hosted server fleet. And we have plenty of customers who heavily use SCIM. And it's surprisingly easy to misconfigure SCIM from the Identity-Provider (IdP) side, which can force a lot of exceptions to bubble up, and eat into our Rollbar budget.
This change allows us to pull the latest version of our fork of the laravel-scim-server, which should give us some slightly better error messaging around some of these common misconfigurations. The change there is this one: grokability/laravel-scim-server#9
The hope is that, instead of throwing a 500 at the server level, we can instead give back a 400-series status code which can at least let the user know that they're sending something that we can't handle. As mentioned in that PR, that's very likely an unknown-subnode of something that we actually do handle - the example I give there was "Fax Number" - we do handles the
phonesattribute, but we do not handle the Fax "type".