Use basic container+box for primary index pages with one column#18454
Merged
Use basic container+box for primary index pages with one column#18454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts to move the most basic index table pages over to use the new container+box blade components. This is one more step towards being able to more easily upgrade the CSS framework. This will also help ensure that we don't have stupid unclosed (or extra closing) divs in our blades which can mangle the formatting.
Ideally, if this works as expected, nothing visually should change.
This will require more fiddling with the container blade component for scenarios where we have two primary columns on listing pages, but this at least gets us started.