Skip to content

Do not delete asset name if update request does not have a name #18470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snipe merged 1 commit into from
Feb 9, 2026
Merged

Do not delete asset name if update request does not have a name #18470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/Http/Controllers/Api/AssetsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,10 @@ public function update(UpdateAssetRequest $request, Asset $asset): JsonResponse
}

if (isset($target)) {
$asset->checkOut($target, auth()->user(), date('Y-m-d H:i:s'), '', 'Checked out on asset update', e($request->input('name')), $location);
// Using `->has` preserves the asset name if the name parameter was not included in request.
$asset_name = request()->has('name') ? request('name') : $asset->name;

$asset->checkOut($target, auth()->user(), date('Y-m-d H:i:s'), '', 'Checked out on asset update', $asset_name, $location);
Copy link
Copy Markdown
Member

@snipe snipe Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to escape that as we were before (via e()) or is it escaped elsewhere?

Copy link
Copy Markdown
Contributor Author

@bilias bilias Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a clue.

I've copied the code from checkout() later on.
If it needs to be escaped it probably has to be escaped in both places.

Also I'm not sure what is better

request('name')
vs
$request->input('name')
vs
$request->get('name')

}

if ($asset->image) {
Expand Down