-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Denorms the 1st checkout date to the asset table #18511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Godmartinz
wants to merge
9
commits into
grokability:develop
Choose a base branch
from
Godmartinz:denorm_1st_checkout_migration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+121
−11
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
16ccb1b
adds action_log index and denorms first check out to assets table
Godmartinz 2af2058
adds migrations
Godmartinz 5f6ecb1
variable rename
Godmartinz eb5b8ae
reduce batchsize
Godmartinz 31578ed
apply first checkout in checkout controller
Godmartinz 100430c
apply first checkout in bulk checkout controller
Godmartinz 307fede
redo backfill query
Godmartinz 7fa0ae9
add cast and attribute accessor
Godmartinz d83fefc
Merge branch 'develop' into denorm_1st_checkout_migration
Godmartinz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
...ions/2026_02_04_222600_add_action_logs_item_type_item_id_action_type_created_at_index.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <?php | ||
|
|
||
| use Illuminate\Database\Migrations\Migration; | ||
| use Illuminate\Database\Schema\Blueprint; | ||
| use Illuminate\Support\Facades\Schema; | ||
|
|
||
| return new class extends Migration | ||
| { | ||
| /** | ||
| * Run the migrations. | ||
| */ | ||
| public function up(): void | ||
| { | ||
| Schema::table('action_logs', function (Blueprint $table) { | ||
Godmartinz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| $table->index(['item_type','item_id','action_type', 'created_at'], | ||
| 'action_logs_item_type_item_id_action_type_created_at_index'); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Reverse the migrations. | ||
| */ | ||
| public function down(): void | ||
| { | ||
| Schema::table('action_logs', function (Blueprint $table) { | ||
| $table->dropIndex('action_logs_item_type_item_id_action_type_created_at_index'); | ||
| }); | ||
| } | ||
| }; | ||
28 changes: 28 additions & 0 deletions
28
database/migrations/2026_02_04_222602_add_first_checkout_at_to_assets_table.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?php | ||
|
|
||
| use Illuminate\Database\Migrations\Migration; | ||
| use Illuminate\Database\Schema\Blueprint; | ||
| use Illuminate\Support\Facades\Schema; | ||
|
|
||
| return new class extends Migration | ||
| { | ||
| /** | ||
| * Run the migrations. | ||
| */ | ||
| public function up(): void | ||
| { | ||
| Schema::table("assets", function (Blueprint $table) { | ||
| $table->timestamp('first_checkout_at')->after('next_audit_date')->nullable(); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Reverse the migrations. | ||
| */ | ||
| public function down(): void | ||
| { | ||
| Schema::table("assets", function (Blueprint $table) { | ||
| $table->dropColumn('first_checkout_at'); | ||
| }); | ||
| } | ||
| }; |
48 changes: 48 additions & 0 deletions
48
database/migrations/2026_02_04_222603_backfill_first_checkout_at_on_assets_table.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <?php | ||
|
|
||
| use App\Models\Actionlog; | ||
| use App\Models\Asset; | ||
| use Illuminate\Database\Migrations\Migration; | ||
| use Illuminate\Database\Schema\Blueprint; | ||
| use Illuminate\Support\Facades\Schema; | ||
|
|
||
| return new class extends Migration | ||
| { | ||
| /** | ||
| * Run the migrations. | ||
| */ | ||
| public function up(): void | ||
| { | ||
| $batchSize = 500; | ||
| $minId = (int)DB::table('assets')->min('id'); | ||
| $maxId = (int)DB::table('assets')->max('id'); | ||
|
|
||
| if (!$minId || !$maxId) { | ||
| return; | ||
| } | ||
|
|
||
| for ($start = $minId; $start <= $maxId; $start += $batchSize) { | ||
| $end = $start + $batchSize - 1; | ||
Godmartinz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| DB::update(" | ||
| UPDATE assets asset | ||
| SET asset.first_checkout_at = ( | ||
| SELECT MIN(log.created_at) | ||
| FROM action_logs log | ||
| WHERE log.item_type = 'App\\\\Models\\\\Asset' | ||
| AND log.action_type = 'checkout' | ||
| AND log.item_id = asset.id | ||
| ) | ||
| WHERE asset.id BETWEEN {$start} AND {$end} | ||
| AND asset.first_checkout_at IS NULL | ||
| "); | ||
| } | ||
| } | ||
| /** | ||
| * Reverse the migrations. | ||
| */ | ||
| public function down(): void | ||
| { | ||
| DB::table('assets')->update(['first_checkout_at' => null]); | ||
| } | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.