Skip to content

Updated subject line of acceptance reminder emails#18542

Merged
snipe merged 15 commits intogrokability:developfrom
marcusmoore:fixes/fd-53577-reminder-subject-2
Feb 12, 2026
Merged

Updated subject line of acceptance reminder emails#18542
snipe merged 15 commits intogrokability:developfrom
marcusmoore:fixes/fd-53577-reminder-subject-2

Conversation

@marcusmoore
Copy link
Copy Markdown
Collaborator

@marcusmoore marcusmoore commented Feb 12, 2026

Recently, we expanded the ability to send acceptance reminders from only assets to include accessories, consumables, and licenses. Along the way we lost the clarity in the subject line of those reminder emails.

Currently, reminder emails reuse the subject line from the initial email ("Asset checked out", "Accessories checked out", "Consumable delivery confirmation", "License delivery confirmation"). This PR adjusts that to say "Reminder: You have Unaccepted Items".

image

In addition, the introduction line in accessory and consumable emails has been fixed:

Before After
image image

Some implementation details:

  • I updated the accessory relationship on the AccessoryCheckout from a hasOne to a belongsTo.
  • I renamed AssetAcceptanceReminderTest to AcceptanceReminderTest since it is testing more than just assets.

[FD-53577]

@marcusmoore marcusmoore marked this pull request as ready for review February 12, 2026 21:18
@marcusmoore marcusmoore requested a review from snipe as a code owner February 12, 2026 21:18
@snipe snipe merged commit 4d73894 into grokability:develop Feb 12, 2026
7 of 8 checks passed
@marcusmoore marcusmoore deleted the fixes/fd-53577-reminder-subject-2 branch February 12, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants