Small importer improvements, added larger CSV samples#18569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the example CSVs with additional support fields, and in some cases includes a
-largeversion which will supply 1000 example records. As always, these do not work the same as the seeders, as the seeders have been carefully crafted to create realistic looking data, while the CSVs are meant to generate more data, so it's not always going to be realistic based off of the available types of object mocks Mockaroo offers.The goal for the
-largeversions is to be able to generate a LOT of data on an import so that we can check for things like 1001 queries.The schemas are available here:
I know Mockaroo can support some clever linking in their generated datasets, so it's possible that we might be able to use this for users, assets, etc - things that are a bit more complicated since they rely on other data to exist.
@uberbrady - don't panic at the lines changed :D It's just the large CSVs.
I've also added a few lines in the importer that strip the whitespace from headers. We ran into an issue where a user was having a problem because their headers were
Model Nameinstead ofModel Name, etc. Hopefully this sorts them out.