Converted consumables to new blade component#18570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the consumables view into the new format, adds a copy+paste, and also fixes a few things with the tabs.
One place where this does get tricky tho is that we generally give the first tab on the screen the
activeclass (same with its corresponding pane), however if a non-superuser doesn't have permission to view that type of FCO, we end up with weird looking tabs. Everything will still work, but you'll have to click off that first tab and then onto it again, which is kind of a crappy UX.I need to figure out how to handle that programmatically in a way that isn't awful.