Adds #9557 Expiring Items Report to GUI: Assets and Licenses#18723
Open
Godmartinz wants to merge 13 commits intogrokability:developfrom
Open
Adds #9557 Expiring Items Report to GUI: Assets and Licenses#18723Godmartinz wants to merge 13 commits intogrokability:developfrom
Godmartinz wants to merge 13 commits intogrokability:developfrom
Conversation
Member
Author
|
Handling conflicts |
# Conflicts: # app/Http/Controllers/Api/ReportsController.php # app/Models/License.php # app/Providers/BreadcrumbsServiceProvider.php # resources/lang/en-US/general.php
Member
Author
|
odd fail for php 8.2 🤔 EDIT: Looks like it was a fluke. |
Godmartinz
changed the title
Godmartinz
changed the title
marcusmoore
requested changes
Mar 17, 2026
Collaborator
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
Can we add tests for those new routes? At least for permissions.
Collaborator
|
Can you also catch this up to develop and run pint? |
marcusmoore
reviewed
Mar 17, 2026
marcusmoore
requested changes
Mar 17, 2026
Collaborator
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
One question to make sure we don't break the existing use of scopeExpiringLicenses but other than that 👍🏾
marcusmoore
approved these changes
Mar 19, 2026
Collaborator
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
One thing to remove but looks good otherwise 👍🏾
Comment on lines
+1
to
+2
| <?php | ||
| ?> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new 'Expiring Items Report' page with Tabs showing Assets and Licenses that are set to expire or terminate:
This info is loaded using API controller and routes
reports/expiring-assetsreports/expiring-licensesCSV Tables:
Adds: #9557