Open
Conversation
Co-authored-by: Brady Wetherington <bwetherington@grokability.com>
Co-authored-by: Brady Wetherington <bwetherington@grokability.com>
Log::setEventDispatcher(Event::fake()) no longer works...
Collaborator
Author
|
I'll fix the docker builds in a bit. |
Collaborator
Author
|
Ok...this is good to go but please check my note on |
Collaborator
Author
|
Conflicts resolved 👍🏾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the application framework to Laravel 12.
Luckily the changes outlined in the changelog mostly don't effect us.
From what I can tell the only thing that potentially requires code changes is the use of
Schema::getTables()in thePaveItcommand but I think it's ok since it's really a dev tool.The following direct dependencies have a major version upgrade:
filter_varin the backup settings is there so docker can successfully build. Without it thepackage:discovercommand that runs when installing fails a validation check that the backup package does.Thanks to @uberbrady for working through a lot of the small code changes in #18726.
Note: in
SnipeTranslatorTest: we had to change topt_BRand I'm not sure that is indicating an issue we need to dig into.