Problem marker decorations missing in Project Explorer

[eric-milles]

Groovy compilation units with error, warning or other problem markers are missing the label decoration in the Project Explorer view, as seen here:

[eric-milles]

Package Explorer uses a different path from the Project Explorer; the latter was added more recently and has more behavior that is pluggable via extension points.

Groovy-Eclipse provides compilation unit images with the following extensions. These should apply to the Navigator view as well, but not the Package Explorer view.

   <extension point="org.eclipse.ui.decorators">
      <decorator
            class="org.codehaus.groovy.eclipse.ui.decorators.GroovyImageDecorator"
            id="org.codehaus.groovy.eclipse.ui.decorator"
            label="Groovy Source File"
            lightweight="false"
            state="true">
         <description>
            Shows an image for Groovy Source files.
         </description>
      </decorator>
   </extension>

   <extension point="org.eclipse.ui.navigator.navigatorContent">
      <navigatorContent
            activeByDefault="true"
            contentProvider="org.eclipse.jdt.internal.ui.navigator.JavaNavigatorContentProvider"
            id="org.codehaus.groovy.eclipse.ui.groovyContent"
            labelProvider="org.codehaus.groovy.eclipse.ui.GroovyNavigatorLabelProvider"
            name="Groovy Sources"
            priority="high">
         <triggerPoints>
            <or>
               <instanceof value="org.codehaus.jdt.groovy.model.GroovyCompilationUnit" />
               <instanceof value="org.eclipse.core.resources.IFile" />
             </or>
         </triggerPoints>
         <possibleChildren>
            <or>
               <instanceof value="org.codehaus.jdt.groovy.model.GroovyCompilationUnit" />
               <instanceof value="org.eclipse.core.resources.IFile" />
            </or>
         </possibleChildren> 
         <override
               policy="InvokeAlwaysRegardlessOfSuppressedExt"
               suppressedExtensionId="org.eclipse.jdt.java.ui.javaContent">
         </override>
      </navigatorContent>
   </extension>

   <extension point="org.eclipse.ui.navigator.viewer">
      <viewerContentBinding viewerId="org.eclipse.ui.navigator.ProjectExplorer">
         <includes>
            <contentExtension pattern="org.codehaus.groovy.eclipse.ui.groovyContent" />
         </includes>
      </viewerContentBinding>
   </extension>

In the Project Explorer, the Java Source content type uses the JavaNavigatorLabelProvider, which delegates to the PackageExplorerLabelProvider to generate icons with overlays. GroovyNavigatorLabelProvider only provides the icon; no overlays.

[eric-milles]

I can get the decorations to display on the compilation unit and child element (if applicable). I'm just doing some extra checking to see if there are any additional views affected by this.

One thing that is still different between Java and Groovy editors is the title image. Java editor shows the problem indicators; I explicitly disabled those some time back. See upper right of this image:

[eric-milles]

Ready to test

[mauromol]

Works well for me in 3.1.0.xx-201809192124-e48!

[wzurborg]

Not sure where to ask and if this is the right place... I am writing my own Explorer with decorations based on Eclipse resource markers. I found that erroneous Groovy source files do not have any markers. Is that true? Would I have to inspect the extensions mentioned in #725 (comment) to derive my decorations?

[eric-milles]

I am writing my own Explorer with decorations based on Eclipse resource markers. I found that erroneous Groovy source files do not have any markers. ... Would I have to inspect the extensions mentioned [above]

Navigator view uses navigatorContent and ILabelProvider extensions. Package Explorer and Project Explorer views use the newer label decorators. I think the older ones are strictly based on content type config and only one applies for a given file. If you are creating your own explorer-style view, you should be able to access the decorator's like the Project Explorer does. GDT registers a decorator for the main image, but relies upon the problems decorator to provide error/warning/info decorations.

[wzurborg]

Ok thanks Eric.