support: Reapply biome configuration for app apiv3 routes (app-settings, page)#10555
Merged
yuki-takei merged 4 commits intodev/7.4.xfrom Dec 4, 2025
Merged
Conversation
…82-app-apiv3-routes-biome-2" This reverts commit a0f5481.
arafubeatbox
changed the title
yuki-takei
deleted the
support/156162-175049-app-apiv3-routes-biome-2-fixed
branch
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ページ取得部分でデグレが生じたことで revert された #10532 を修正し、再適用するための PR。
デグレの内容
どのページ取得結果も 404 となる。
デグレの原因
45e8b16 のコミットでページ取得 API 内の pages 変数にデフォルト値として空の配列を設定したが、pages が undefined ではなく空の配列の場合は「ページが見つからなかった」という結果にする仕様だった。
修正内容
https://github.com/growilabs/growi/pull/10555/files/fe1dfce0a16f81b3b7d65bf4a545bf33ed2ff4e4..225dd23a7a50bf1fa98dace730708d0b02c6fd2e
ページ検索が findAll かそうでない場合かの処理を分離し、pages パラメータの定義やその結果による処理を findAll: true の文脈で完結するように修正。
これにより、findAll: false の文脈のために pages を undefined で定義しておく必要がなくなる。
動作確認
task
https://redmine.weseek.co.jp/issues/175049