Skip to content

support: Configure biome for some app server services#10574

Merged
yuki-takei merged 10 commits intodev/7.4.xfrom
support/156162-174669-app-server-service-biome-1
Dec 8, 2025
Merged

support: Configure biome for some app server services#10574
yuki-takei merged 10 commits intodev/7.4.xfrom
support/156162-174669-app-server-service-biome-1

Conversation

@arafubeatbox
Copy link
Contributor

@arafubeatbox arafubeatbox commented Dec 7, 2025

What

  • app の server services (子ディレクトリが切られていないもの) の biome 移行。

biome 自動修正不可だった差分

動作確認

  • attachment のアップロードができることを確認

task

https://redmine.weseek.co.jp/issues/174669

@arafubeatbox arafubeatbox changed the title Support/156162 174669 app server service biome 1 support: Configure biome for some app server services Dec 7, 2025
@@ -1,14 +1,19 @@
import { ConfigSource } from '@growi/core';
import type { IUser } from '@growi/core/dist/interfaces';
// biome-ignore lint/style/noRestrictedImports: TODO: check effects of using custom axios
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rawAxios としてインポートされていたため、動作確認の手間も考慮し念の為元の axios をそのまま利用。

@@ -1,4 +1,5 @@
function getAxios(team, token) {
// biome-ignore lint/style/noRestrictedImports: TODO: check effects of using custom axios
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作確認の手間も考慮し念の為元の axios をそのまま利用。

@arafubeatbox arafubeatbox marked this pull request as ready for review December 7, 2025 09:55
@yuki-takei yuki-takei merged commit 2e50c64 into dev/7.4.x Dec 8, 2025
12 of 15 checks passed
@yuki-takei yuki-takei deleted the support/156162-174669-app-server-service-biome-1 branch December 8, 2025 07:57
@github-actions github-actions bot mentioned this pull request Dec 8, 2025
@yuki-takei yuki-takei mentioned this pull request Dec 19, 2025
This was referenced Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants