Conversation
miya
commented
Dec 11, 2025
| } | ||
| }, [create, isNotFound, setEditorMode]); | ||
|
|
||
| }; |
Member
Author
There was a problem hiding this comment.
PageEditorModeManager.tsx の editButtonClickedHandler の内部実装を hook として切り出した
| // remove this | ||
| props.onDeleteRender(this); | ||
| })(); | ||
| }, [startEditing, isEditable, path, props, setEditorMode, t]); |
Member
Author
There was a problem hiding this comment.
ショートカット (e) 実行時に空ページの場合はページを作成できるようにした
yuki-takei
requested changes
Dec 12, 2025
| await startEditing(path); | ||
| } | ||
| catch (err) { | ||
| toastError(t('toaster.create_failed', { target: path })); |
Contributor
There was a problem hiding this comment.
hook の中に toastr 処理が入るのはやだな
Member
Author
There was a problem hiding this comment.
useEditPage (ロジックレイヤー) と EditPage (UI レイヤー) に分けて、toastr 処理を EditPage 側に定義して useEditPage のコールバック関数として渡すようにリファクタしました。
miya
deleted the
feat/175737-can-create-page-when-executing-page-edit-shortcut-key-on-empty-page
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
https://redmine.weseek.co.jp/issues/175737