fix: restore backward compatibility of with* methods (regression from v1.7.3)#59
Merged
vazarkevych merged 1 commit intogrowthbook:masterfrom Mar 26, 2026
Conversation
…lity with* methods in v1.7.3 were changed to immutable (clone-based), which introduced a breaking change in a patch release, violating semver. This restores with* to mutable behavior (as in v1.7.2) and marks them as @deprecated in favor of the new set* equivalents. The with* methods will become properly immutable in v2.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
v1.7.3 introduced a breaking change: all
with*methods were made immutable (returning a cloned instance instead of modifying$this). This broke existing code without any error or warning, violating semantic versioning.Solution
Restored mutable behavior of
with*methods to match v1.7.2. Added@deprecatedannotations on allwith*methods pointing to theirset*equivalents to prepare users for the upcoming v2.0.0.