examples/features/csm_observability: use helloworld client and server instead of echo client and server#7945
Conversation
purnesh42H
force-pushed
the
update-opentelemtry-example-to-hew
branch
from
fe9087f to
690c2c1
Compare
|
|
||
| func (s *echoServer) UnaryEcho(_ context.Context, req *pb.EchoRequest) (*pb.EchoResponse, error) { | ||
| return &pb.EchoResponse{Message: fmt.Sprintf("%s (from %s)", req.Message, s.addr)}, nil | ||
| // SayHello implements helloworld.GreeterServer |
There was a problem hiding this comment.
SayHello is a method, it's inaccurate to say that it implements an interface. I believe this comment should be on server instead.
There was a problem hiding this comment.
Actually, this is what we have in every example. I just took it from helloworld and observability example
arjan-bal
left a comment
arjan-bal
left a comment
There was a problem hiding this comment.
Did you manually run the client and server to verify they work?
yes, i checked the output on server and client and prometheous |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7945 +/- ##
==========================================
- Coverage 82.15% 82.03% -0.12%
==========================================
Files 381 381
Lines 38539 38539
==========================================
- Hits 31660 31615 -45
- Misses 5574 5600 +26
- Partials 1305 1324 +19 |
arjan-bal
left a comment
arjan-bal
left a comment
There was a problem hiding this comment.
Looks good, should complete testing in k8s before merging.
purnesh42H
force-pushed
the
update-opentelemtry-example-to-hew
branch
from
8d08898 to
6db15dc
Compare
purnesh42H
changed the title
purnesh42H
force-pushed
the
update-opentelemtry-example-to-hew
branch
from
b599957 to
127f91c
Compare
… instead of echo client and server (grpc#7945)
3 participants
RELEASE NOTES: