clustermanager: fix test logic waiting for picker during graceful switch#9072
Open
easwars wants to merge 1 commit intogrpc:masterfrom
Open
clustermanager: fix test logic waiting for picker during graceful switch#9072easwars wants to merge 1 commit intogrpc:masterfrom
easwars wants to merge 1 commit intogrpc:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9072 +/- ##
==========================================
- Coverage 80.90% 80.53% -0.38%
==========================================
Files 413 413
Lines 33509 33543 +34
==========================================
- Hits 27111 27013 -98
- Misses 4299 4315 +16
- Partials 2099 2215 +116 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8995
The test was waiting for an event that was not expected to happen, but was waiting for it with the test context instead of a short context. This is the offending line: https://github.com/grpc/grpc-go/blob/master/internal/xds/balancer/clustermanager/clustermanager_test.go#L668-L672
I ended up cleaning the test up, adding comments to make it more readable, and removing a stub policy that was not being used in anyway.
RELEASE NOTES: none