Conversation
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Thanks for doing this! Please let me know if you have any questions.
There was a problem hiding this comment.
Thanks for the detailed review. The content of this design doc has been trimmed down as suggested.
@markdroth PTALA.
lidizheng
left a comment
lidizheng
left a comment
There was a problem hiding this comment.
Thanks for the detailed review. I have resolved most comments. But not sure about the more languages one. I can add Python for sure, but for Ruby PHP Node.js, I might want to involve language owners to see if the design works.
A38-admin-interface-api.md
Outdated
|
|
||
| ## Abstract | ||
|
|
||
| This proposal describes a convenience API in each gRPC language to improve the usability of creating a gRPC server with admin services to expose states in the gRPC library. |
There was a problem hiding this comment.
nit: s/convenience/convenient/ ?
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Just a couple of remaining comments here. Overall, looks very good!
|
@markdroth PTALAAA. I think all open comments are resolved in this gRFC, and the configuration dump part is split into another gRFC. |
6 participants
gRFC: https://github.com/lidizheng/proposal/blob/admin-interface/A38-admin-interface-api.md
This proposal describes a convenience API in each gRPC language to improve the usability of creating a gRPC server with admin services.