Wizards background shifts to gray when focusing, looks bad.

[krypto5863]

Describe the bug
Focusing on a wizard window tends to make the background gray which tends to mess up the look.

To Reproduce
Open a wizard and click the view. It's most noticeable with textboxes an stuff.

Expected behavior
I expected the clicked element, buttons/textboxes/etc,. to change color to show they're focused, instead the whole window went gray.

Screenshots

[BDisp]

That isn't happening with me on both v1 and v2.

[krypto5863]

That's strange, I'm just running UI catalog, haven't touched anything in the project either, happens with my own separate project where I get Terminal.GUI via nuget also.

[BDisp]

Maybe the nuget package isn't yet updated with the current develop branch.

[krypto5863]

Nuget version reads 1.10.1, but I cloned the repo to run the UICatalog, so it shouldn't matter anyways.

[WayneHiller]

I am having the same issue.

[tznind]

Here is a minimum repro

Its probably not much consolation but this does seem to be fixed in v2_develop

using Terminal.Gui;

Application.Init();

var w = new Window();

var label = new Label("I'm outside wizard:");
var tf = new TextField("yay") { X = 20, Width = 20 };
w.Add(label);
w.Add(tf);

var wizard = new Wizard
{
    X = 0,
    Y = 1,
    Width = Dim.Fill(),
    Height = Dim.Fill(),
    Modal = false,
    TabStop = true
};

var step = new Wizard.WizardStep("Yarg");
step.Add(new Label("SomeText:"));
step.Add(new TextField() { Y=1,Width = 10});
step.Add(new Label("SomeText2:") { Y = 2, });
step.Add(new TextField() { Y = 3, Width = 10 });

wizard.AddStep(step);


var step2 = new Wizard.WizardStep("Blerg");
step2.Add(new Label("SomeText3:"));
step2.Add(new TextField() { Y = 1, Width = 10 });
wizard.AddStep(step2);

w.Add(wizard);

Application.Run(w);

Application.Shutdown();

[Pieshka]

It's happening in my project too. The example above also produces identical effect. I found out, that this started to happen after this commit. When rolled back to previous commit, background is not shifting to gray anymore. That problem also occures on version 1.12.1 and latest develop commit, so it's not fixed yet.

[tig]

I'll look into this asap!

[Pieshka]

It turns out that the problem does not only occur with Wizard, but also with TabView. You can see this using the code below, but the TabView Demo from UICatalog (tab "Interactive Tab") also has this bug.

Application.Init();
Toplevel top = Application.Top;
Window mainWindow = new Window("MainWindow");

View tabTestView = new View() { Height = Dim.Fill(), Width = Dim.Fill() };
tabTestView.Add(new Label("SomeText:") { Y = 0 });
tabTestView.Add(new TextField() { Y = 1, Width = 10 });
tabTestView.Add(new Label("SomeText2:") { Y = 2 });
tabTestView.Add(new TextField() { Y = 3, Width = 10 });

TabView tabs = new TabView() 
{ 
    Width = Dim.Fill(),
    Height = Dim.Fill()
};
tabs.AddTab(new TabView.Tab("Tab1", tabTestView),false);
mainWindow.Add(tabs);
top.Add(mainWindow);
Application.Run();
Application.Shutdown();

[BDisp]

The fix was done @Piotr86PL in f019826.
In the v1 if we don't want a View to being clear we must initialize it through a View derived private class.