Fix issue where the TestViewsDisposeCorrectly was not doing what it was supposed to do#2964
Merged
tig merged 28 commits intogui-cs:developfrom Nov 15, 2023
Merged
Fix issue where the TestViewsDisposeCorrectly was not doing what it was supposed to do#2964tig merged 28 commits intogui-cs:developfrom
tig merged 28 commits intogui-cs:developfrom
Conversation
Author
|
While testing this i found out that toplevels create multiple references to their subviews that arent being released upon disposal. |
This reverts commit 0c2183e.
…se the Toplevel property.
Dispose tests fix
…disposed (not just container)
Author
|
|
TestVKPacket is acting up again. Maybe the test is running async and is receiving scan codes from other instances?
tig
reviewed
Nov 15, 2023
tig
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit // test fails now (which is good, as the reason for that is that a certain view doesnt dispose correctly.)///style comments)