Skip to content

Fixes #2970. ScrollView doesn't remove a view that was previously added on both versions.#2971

Merged
tig merged 1 commit intogui-cs:developfrom
BDisp:v1_scrollview-remove-fix_2970
Nov 15, 2023
Merged

Fixes #2970. ScrollView doesn't remove a view that was previously added on both versions.#2971
tig merged 1 commit intogui-cs:developfrom
BDisp:v1_scrollview-remove-fix_2970

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Nov 10, 2023

Fixes #2970 for v1 - The Remove method wasn't override.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner November 10, 2023 16:40
@tig tig merged commit 91865ee into gui-cs:develop Nov 15, 2023
@BDisp BDisp deleted the v1_scrollview-remove-fix_2970 branch November 15, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ScrollView doesn't remove a view that was previously added on both versions.

2 participants