Skip to content

Fixes #2987. Set a MdiChild visible to false still processes keystrokes.#2988

Merged
tig merged 1 commit intogui-cs:developfrom
BDisp:v1-mdichild-visible-false-keystroke-fix_2987
Nov 15, 2023
Merged

Fixes #2987. Set a MdiChild visible to false still processes keystrokes.#2988
tig merged 1 commit intogui-cs:developfrom
BDisp:v1-mdichild-visible-false-keystroke-fix_2987

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Nov 14, 2023

Fixes #2987 - Application should only propagate keystrokes for visible toplevels.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner November 14, 2023 00:45
@tig tig merged commit c348cda into gui-cs:develop Nov 15, 2023
@BDisp BDisp deleted the v1-mdichild-visible-false-keystroke-fix_2987 branch November 15, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set a MdiChild visible to false still processes keystrokes.

2 participants