Fixes #3178. v1 - Library has no strong-name.

[ilCosmico]

Add strong-name signing.

Fixes

• Fixes Enable strong name for Terminal.Gui v1 #3178

Proposed Changes/Todos

• Add snk file
• Add strong naming sign

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[ilCosmico]

I suppose that NStack library should be strong-named too.

[ilCosmico]

All tests passed!

BTW I'm not so expert on this library, so I don't know how "to assure all features are working".

[ilCosmico]

Created PR #91 for NStack.

I tried to build again this version of Terminal.Gui with it and strong-name warning has now disappeared.

[tig]

BTW I'm not so expert on this library, so I don't know how "to assure all features are working".

Yeah, that's worded a bit unfairly.

Please, at least, do this:

• Run the All Views Tester Scenario and select each view. Ensure nothing really odd happens.
• Try a bunch of Scenarios. Some are more complex and tend to push the envelope and are good at sniffing out issues:
  • CharMap
  • Scrolling
  • Text Formatting
  • Editor
  • Dialogs
  • Wizards
• Do the above under WSL
• Do the above with -usc on both Windows and WSL

[ilCosmico]

@tig, @BDisp, I just added a strong-name option without changing the code. I don't think it compromises the library's running, do you?

[BDisp]

I don't think so and the tests pass. But you have to wait for @tig's decision.

[tig]

Do I need to do anything other than merge this for it to work for publishing to Nuget?

I was expecting to have to generate a private key that we'd need to store in a github secret or something.

[ilCosmico]

It is not necessary to generate a password for the .snk file for strong name purposes, so you just need to merge it. Thank you, @tig.

[tig]

Ok, NStack v1.1.1 is published with an SN.

Now for Terminal.Gui...

[tig]

v1.15.1 is published.

Please verify that I didn't screw something up ;-)