Skip to content

Fixes #2095. Resizing when a context menu is open causes the Enter event to get spammed#3193

Merged
tig merged 2 commits intogui-cs:developfrom
BDisp:v1_contextmenu-resize_2095
Jan 20, 2024
Merged

Fixes #2095. Resizing when a context menu is open causes the Enter event to get spammed#3193
tig merged 2 commits intogui-cs:developfrom
BDisp:v1_contextmenu-resize_2095

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Jan 19, 2024

Fixes

Proposed Changes/Todos

  • ContextMenu now close on terminal resizing

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner January 19, 2024 22:34
@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Jan 19, 2024

@tig do you know why this warning is showing?

image

Copy link
Copy Markdown
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@tig tig merged commit b65092f into gui-cs:develop Jan 20, 2024
@BDisp BDisp deleted the v1_contextmenu-resize_2095 branch January 20, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resizing when a context menu is open causes the Enter event to get spammed

2 participants