Skip to content

Fixes #2252. Pressing the ENTER key in a TextField should not move the focus#3195

Merged
tig merged 3 commits intogui-cs:developfrom
BDisp:v1_button-isdefault-does-not-get-focus-on-enter-key_2252
Jan 20, 2024
Merged

Fixes #2252. Pressing the ENTER key in a TextField should not move the focus#3195
tig merged 3 commits intogui-cs:developfrom
BDisp:v1_button-isdefault-does-not-get-focus-on-enter-key_2252

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Jan 20, 2024

Fixes

Proposed Changes/Todos

  • IsDefault true doesn't get the focus on the Enter key unless it's already focused.
  • Add unit test

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner January 20, 2024 01:40
@tig tig merged commit ce7ecb5 into gui-cs:develop Jan 20, 2024
@BDisp BDisp deleted the v1_button-isdefault-does-not-get-focus-on-enter-key_2252 branch January 20, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pressing the ENTER key in a TextField should not move the focus

2 participants