Skip to content

Fixes #3318. v1-MouseClick should be invoked only once on a mouse click.#3320

Merged
tig merged 3 commits intogui-cs:developfrom
BDisp:v1_mouseclick-fix_3318
Mar 16, 2024
Merged

Fixes #3318. v1-MouseClick should be invoked only once on a mouse click.#3320
tig merged 3 commits intogui-cs:developfrom
BDisp:v1_mouseclick-fix_3318

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Mar 13, 2024

Fixes

Proposed Changes/Todos

  • Only consider clicked event of any button
  • Added unit test for proof

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner March 13, 2024 21:13
Copy link
Copy Markdown
Collaborator

@dodexahedron dodexahedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread safety and performance comment for the new code and a terminology nitpick for the test method.

Comment thread Terminal.Gui/Core/View.cs Outdated
Comment thread UnitTests/Views/ViewTests.cs Outdated
@tig tig merged commit 26c06d7 into gui-cs:develop Mar 16, 2024
@BDisp BDisp deleted the v1_mouseclick-fix_3318 branch March 16, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1-MouseClick should be invoked only once on a mouse click.

3 participants