Skip to content

Fixes #3351 (V1). TabIndex with the same setter value but with wrong index return without set the correct value.#3352

Merged
tig merged 2 commits intogui-cs:developfrom
BDisp:v1_tabindex-fix_3351
Mar 31, 2024
Merged

Fixes #3351 (V1). TabIndex with the same setter value but with wrong index return without set the correct value.#3352
tig merged 2 commits intogui-cs:developfrom
BDisp:v1_tabindex-fix_3351

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Mar 26, 2024

Fixes

Proposed Changes/Todos

  • Check if the index also belong to the view.
  • Add unit test to proof

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

… index return without set the correct value.
@BDisp BDisp requested a review from tig as a code owner March 26, 2024 23:56
@tig tig changed the title Fixes #3351. TabIndex with the same setter value but with wrong index return without set the correct value. Fixes #3351 (V1). TabIndex with the same setter value but with wrong index return without set the correct value. Mar 31, 2024
@tig tig merged commit f7ac933 into gui-cs:develop Mar 31, 2024
@BDisp BDisp deleted the v1_tabindex-fix_3351 branch March 31, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TabIndex with the same setter value but with wrong index return without set the correct value.

2 participants