Fix potential github action smells

[ceddy4395]

Fixes

Hey! 🙂
I want to contribute the following changes to your workflow:

• Avoid running CI related actions when no source code has changed
• Avoid executing scheduled workflows on forks
• Avoid jobs without timeouts

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

Proposed Changes/Todos

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[dodexahedron]

LGTM

Thanks!

Plenty more we could do, too, but these hit some really big sources of noise. 👍

[dodexahedron]

Also, a thought for future consideration for us before it disappears from my head again:

Especially with regards to Roslyn analyzers/generators, we may want to consider caching, so that they don't have to get built every time, unless one of the analyzer projects is actually modified. Would speed up the build actions. Efficiency of those actions does matter, because there is a limit to how much execution time is allowed per month.

[dodexahedron]

Still fine to me, regardless of comments I just added.

Those are notes for me while I'm completely re-working things and aren't related to the changes made.

[tig]

Is this ready for me to merge?

[dodexahedron]

Hey @tig :

Closely related to this, and also might influence what gets added to the gh marketplace action I'm working on:

What do you have the "Actions permissions" and "Workflow Permissions" set to for this repository, under settings > actions > general? I wanna be sure this repo is covered from the start, since it was the original catalyst for making me do it now rather than [undefined future time range] in the first place. :)

And do you have any environments configured? (that's not important - just surveying what's in use here).

And any defined rulesets or branch/tag protections?

Also, any difficulties or wish list items vis-a-vis the actions/workflows/deployment/builds/etc?

Aside from splitting the analyzers - that is dependent on these other tasks I've got outstanding.