Skip to content

Fixes #3496. Escape Key not invoking OnKeyDown on Unix.#3511

Merged
tig merged 1 commit intogui-cs:developfrom
BDisp:v1_3496-esc-key-onkeydown-unix-fix
May 29, 2024
Merged

Fixes #3496. Escape Key not invoking OnKeyDown on Unix.#3511
tig merged 1 commit intogui-cs:developfrom
BDisp:v1_3496-esc-key-onkeydown-unix-fix

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented May 29, 2024

Fixes

Proposed Changes/Todos

  • Add call to the keyDownHandler for the Esc key

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner May 29, 2024 13:48
@tig tig merged commit 881686b into gui-cs:develop May 29, 2024
@BDisp BDisp deleted the v1_3496-esc-key-onkeydown-unix-fix branch May 29, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Escape Key not invoking OnKeyDown on Window or Toplevel

2 participants